fix: show bacalhau id error #192
Conversation
|
bacalhau id have error and when runing rp, lilypad not print pow worker message this pr return this error, and tell user you got sometheing error |
hunjixin
force-pushed
the
fix/show_bacalhau_id_error
branch
2 times, most recently
from
7a802d0 to
402da7b
Compare
|
add a new commit to resolve this problem, cmd output some odd error log. just parse the last line @AquiGorka |
| if err != nil { | ||
| return "", fmt.Errorf("error calling get id results %s", err.Error()) | ||
| } | ||
|
|
||
| splitOutputs := strings.Split(strings.Trim(string(runOutputRaw), " \t\n"), "\n") | ||
| runOutput := splitOutputs[len(splitOutputs)-1] |
There was a problem hiding this comment.
errOutput = splitOutputs[1:]
if errOutput != nil {
return "", fmt.Errorf("error unmarshalling job JSON %s %s", err.Error(), errOutput)
}There was a problem hiding this comment.
add like this?, but i got a panic in this change. i dont know how the error log look like
There was a problem hiding this comment.
If you are getting errors, it means there is something wrong, you also need to trim, I added a similar change recently, here: https://github.com/Lilypad-Tech/lilypad/pull/175/files
Let's make sure we also capture errors if there are errors
There was a problem hiding this comment.
@AquiGorka I've updated to add logging for error output.
@hunjixin Looks like we want splitOutputs[:len(splitOutputs)-1] (i.e. everything but the last line).
There was a problem hiding this comment.
this change seem to make things not work.the output in my comment
1 line: error log
1 line: id result
1 line: empty line
this is why add a trim to make sure the empty line is removed
split by \n, 4 lines, with 2 empty line in last
hunjixin
force-pushed
the
fix/show_bacalhau_id_error
branch
from
402da7b to
91a12b4
Compare
walkah
force-pushed
the
fix/show_bacalhau_id_error
branch
from
91a12b4 to
8e82923
Compare
|
In discussing with @taoshengshi - if we can get this merged, he can do testing in the morning (china time) with RPs to confirm this unblocks the issue. |
Review Type Requested (choose one):
show error in "bacalhau id" command.
Summary
Provide a one line summary and link to any relevant references
Task/Issue reference
Re: https://github.com/Lilypad-Tech/hni/issues/7
Details (optional)
Add any additional details that might help Code Reviewers digest this PR
How to test this code? (optional)
Anything else? (optional)