fix: tracking job offer update events #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AquiGorka
requested review from
arsen3d,
10d9e,
richardbremner,
bgins,
noryev and
taoshengshi
AquiGorka
commented
Jun 26, 2024
| @@ -16,8 +16,9 @@ const nodeInfoEndpoint = "nodes" | |||
| const nodeConnectionEndpoint = "uptimes" | |||
| const dealsEndpoint = "deals" | |||
|
|
|||
| var host = os.Getenv("API_HOST") | |||
There was a problem hiding this comment.
@walkah I moved this out of the function call, I don't think we need to call it every time the function executes right?
There was a problem hiding this comment.
You're absolutely right! Good catch 👍
walkah
approved these changes
Jun 26, 2024
| @@ -16,8 +16,9 @@ const nodeInfoEndpoint = "nodes" | |||
| const nodeConnectionEndpoint = "uptimes" | |||
| const dealsEndpoint = "deals" | |||
|
|
|||
| var host = os.Getenv("API_HOST") | |||
There was a problem hiding this comment.
You're absolutely right! Good catch 👍
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review Type Requested (choose one):
Summary
These changes make it so that tracking the job offer update is not a subscription to job offer updates but a method call right before the subscriptions are executed.
Details (optional)
Why?
I wish I knew why the previous way was not working, locally it worked, so the assumption was that it would also work in the deployed infra.
I have a hypothesis the previous subscription was part of the client code and because the client should not have access to the
API_HOSTenv var the requests should not have been going out, but as it happens, the doppler settings forrundid include theAPI_HOST- although, after removing it, locally the events would be still tracked 🤷 .How to test this code? (optional)
jobstable in the db has the corresponding job entry (in the api repo:./stack psql, thenSELECT * FROM jobs;)