Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update docker context on hardhat processes #208

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

arsen3d
Copy link
Contributor

@arsen3d arsen3d commented Jun 27, 2024

Review Type Requested (choose one):

  • [x ] Logic - thorough check (from everybody doing review)

Summary

Fixed docker permissions error requiring sudo.

@AquiGorka
Copy link
Contributor

Ahhh, good find, this way the docker processes creating the files will create such files with your current user + group instead of root (docker default).
Can you verify the process for boot still works on macos and linux? (have someone else on the team help out if you don't have access to mac and/or linux, I'm currently swamped if not I'd be offering to help)

@arsen3d
Copy link
Contributor Author

arsen3d commented Jun 27, 2024

Issue: #106

@AquiGorka AquiGorka changed the title fix: windows docker permissions chore: update docker context on hardhat processes Jul 9, 2024
@AquiGorka AquiGorka force-pushed the arsen/fix-windows-docker-permission branch from 972baf9 to a8d67c3 Compare July 9, 2024 14:15
@AquiGorka AquiGorka merged commit 2500d68 into main Jul 9, 2024
1 check passed
@AquiGorka AquiGorka deleted the arsen/fix-windows-docker-permission branch July 9, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants