feat: Add VRAM and disk space matching #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgins
changed the title
bgins
changed the title
bgins
force-pushed
the
bgins/feat-add-vram-and-disk-matching
branch
from
d0384bd to
33a3bc0
Compare
walkah
approved these changes
Dec 18, 2024
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request makes the following changes:
We want the Solver matching algorithm to match on minimum VRAM and disk space. This pull request implements these constraints.
Task/Issue reference
Closes: #470
Test plan
We have added new test cases for VRAM and disk space to our matcher test suite. Run the tests with:
Start the stack. Run a job. Our usual test procedure ensures this pull request does not break anything, but note that it does not exercise cases where a job creator requests VRAM or disk space.
Details
Resource providers currently report VRAM and disk space in resource offers.
The job offer includes a machine spec, but we have not implemented CLI options for setting GPUs (with VRAM) or disk space. As a result, GPUs and disk space use default zero values, empty slice and
0respectively.Related issues or PRs
Epic: https://github.com/Lilypad-Tech/internal/issues/367