Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify types: PublicKey and Address32 #273

Merged
merged 12 commits into from
Nov 10, 2023
Merged

Unify types: PublicKey and Address32 #273

merged 12 commits into from
Nov 10, 2023

Conversation

nicksinch
Copy link
Contributor

@nicksinch nicksinch commented Nov 7, 2023 •
edited
Loading

Detailed description:

  • Adds 3 new types for public key purposes -> Ed25519PublicKey, Sr25519PublicKey and EcdsaPublicKey
  • The three new types are embedded into the AccountId type used for a generic public key type
  • which public key is to be used is now configured in the runtime.go using the corresponding type
  • Adds tests for the 3 new types
  • obsoletes (removes) the type PublicKey

Which issue(s) this PR fixes:
#239

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@nicksinch nicksinch requested a review from radkomih November 7, 2023 15:02
@nicksinch nicksinch changed the title Merge pubkey addr32 Unify types: PublicKey and Address32 Nov 7, 2023
radkomih
radkomih reviewed Nov 8, 2023
View reviewed changes
api/account_nonce/module.go Outdated Show resolved Hide resolved
primitives/types/account_id.go Show resolved Hide resolved
@radkomih radkomih requested a review from tgntr November 8, 2023 07:49
@radkomih radkomih requested a review from failfmi November 8, 2023 09:14
radkomih
radkomih reviewed Nov 8, 2023
View reviewed changes
runtime/runtime.go Outdated Show resolved Hide resolved
radkomih
radkomih reviewed Nov 8, 2023
View reviewed changes
execution/types/unchecked_extrinsic.go Show resolved Hide resolved
primitives/types/account_id.go Outdated Show resolved Hide resolved
primitives/types/public_key.go Outdated Show resolved Hide resolved
@nicksinch nicksinch force-pushed the merge-pubkey-addr32 branch 3 times, most recently from cee0ea0 to eeedc33 Compare November 9, 2023 22:53
@failfmi failfmi self-requested a review November 10, 2023 07:22
failfmi
failfmi reviewed Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@failfmi failfmi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits to refactor [S] -> [T]

@failfmi failfmi self-requested a review November 10, 2023 13:12
@nicksinch nicksinch merged commit 301443d into develop Nov 10, 2023
@nicksinch nicksinch deleted the merge-pubkey-addr32 branch November 10, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@failfmi failfmi failfmi approved these changes

@radkomih radkomih radkomih approved these changes

@tgntr tgntr Awaiting requested review from tgntr

Assignees

@nicksinch nicksinch

Labels
None yet
Projects
Gosemble - Polkadot Runtimes
Status: ✅ Done
Milestone
Phase 2 - M2 - Fixes and Improvements
Development

Successfully merging this pull request may close these issues.
3 participants
@nicksinch @radkomih @failfmi