Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inherent error, mocks, timestamp critical #292

Merged
merged 2 commits into from
Nov 17, 2023
Merged

fix: inherent error, mocks, timestamp critical #292

merged 2 commits into from
Nov 17, 2023

Conversation

failfmi
Copy link
Collaborator

@failfmi failfmi commented Nov 16, 2023

Detailed description:

  • fix storage value mock funcs
  • fix inherent error inherent identifier to be fixed sequence
  • fix timestamp flow
  • add tests

Which issue(s) this PR fixes:
Fixes #286

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@failfmi failfmi self-assigned this Nov 16, 2023
@failfmi failfmi linked an issue Nov 16, 2023 that may be closed by this pull request
fix InherentError type #286
Closed
tgntr
tgntr reviewed Nov 16, 2023
View reviewed changes
frame/timestamp/module.go Outdated Show resolved Hide resolved
@failfmi failfmi merged commit c562a88 into develop Nov 17, 2023
@failfmi failfmi deleted the fix/inherent-error branch November 17, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgntr tgntr tgntr approved these changes

@radkomih radkomih radkomih approved these changes

@nicksinch nicksinch Awaiting requested review from nicksinch

Assignees

@failfmi failfmi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix InherentError type
3 participants
@failfmi @tgntr @radkomih