Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: implement error interface and improve error resolving #295

Merged
merged 10 commits into from
Nov 23, 2023

Conversation

tgntr
Copy link
Collaborator

@tgntr tgntr commented Nov 20, 2023

Detailed description:

Which issue(s) this PR fixes:
Fixes #271

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@tgntr tgntr linked an issue Nov 21, 2023 that may be closed by this pull request
@tgntr tgntr requested a review from radkomih November 21, 2023 10:11
build/runtime.wasm Outdated Show resolved Hide resolved
@tgntr tgntr requested a review from failfmi November 21, 2023 15:25
execution/types/checked_extrinsic.go Outdated Show resolved Hide resolved
primitives/types/arithmetic_error.go Outdated Show resolved Hide resolved
@failfmi failfmi self-requested a review November 22, 2023 08:17
failfmi
failfmi previously approved these changes Nov 22, 2023
radkomih
radkomih previously approved these changes Nov 22, 2023
@tgntr tgntr dismissed stale reviews from radkomih and failfmi via f528c19 November 22, 2023 10:32
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 76 lines in your changes are missing coverage. Please review.

Comparison is base (aa67dff) 77.33% compared to head (ad27a05) 77.99%.

Files Patch % Lines
primitives/types/invalid_transaction.go 0.00% 29 Missing ⚠️
primitives/types/transaction_validity_error.go 62.50% 8 Missing and 1 partial ⚠️
primitives/types/arithmetic_error.go 66.66% 6 Missing and 1 partial ⚠️
primitives/types/dispatch_errors.go 89.23% 7 Missing ⚠️
primitives/types/token_error.go 80.55% 6 Missing and 1 partial ⚠️
primitives/types/transactional_error.go 61.11% 6 Missing and 1 partial ⚠️
primitives/types/unknown_transaction.go 61.53% 4 Missing and 1 partial ⚠️
primitives/types/lookup.go 50.00% 2 Missing and 1 partial ⚠️
frame/executive/executive.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #295      +/-   ##
===========================================
+ Coverage    77.33%   77.99%   +0.66%     
===========================================
  Files          156      156              
  Lines        10277    10363      +86     
===========================================
+ Hits          7948     8083     +135     
+ Misses        1946     1908      -38     
+ Partials       383      372      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tgntr tgntr requested review from failfmi and radkomih November 23, 2023 12:40
@tgntr tgntr merged commit 79295d5 into develop Nov 23, 2023
5 checks passed
@tgntr tgntr deleted the refactor/errors branch November 23, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement the Error interface
3 participants