Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parachain compatibility #412

Merged
merged 18 commits into from
Jun 14, 2024
Merged

feat: parachain compatibility #412

merged 18 commits into from
Jun 14, 2024

Conversation

failfmi
Copy link
Collaborator

@failfmi failfmi commented May 22, 2024

Description

  • modules
    • aura-ext
      • block executor
    • parachain-system
  • api
    • collect_collation_info
    • validate_block
  • internal trie representation for io.Storage and io.TransactionBroker

Fixes #374

Checklist:

  • I have read the contributing guidelines.
  • My PR title matches the Conventional Commits spec.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I can start a Substrate node using the updated runtime.

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 23.53995% with 2134 lines in your changes missing coverage. Please review.

Project coverage is 67.91%. Comparing base (095050b) to head (bd83e0f).

Files Patch % Lines
frame/parachain_system/module.go 0.00% 532 Missing ⚠️
frame/parachain_system/metadata.go 0.00% 416 Missing ⚠️
primitives/pvf/host_environment.go 0.00% 130 Missing ⚠️
frame/parachain_system/call_set_validation_data.go 0.00% 129 Missing ⚠️
primitives/parachain/relay_chain_state_proof.go 5.19% 71 Missing and 2 partials ⚠️
primitives/parachain/state_proof_error.go 0.00% 52 Missing ⚠️
utils/decoder/decoder.go 44.31% 39 Missing and 10 partials ⚠️
primitives/parachain/user_bandwidth.go 0.00% 46 Missing ⚠️
frame/parachain_system/call_send_upward_message.go 0.00% 41 Missing ⚠️
api/parachain/module.go 61.25% 16 Missing and 15 partials ⚠️
... and 49 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #412      +/-   ##
===========================================
- Coverage    76.25%   67.91%   -8.34%     
===========================================
  Files          307      366      +59     
  Lines        15356    18023    +2667     
===========================================
+ Hits         11710    12241     +531     
- Misses        3144     5196    +2052     
- Partials       502      586      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@failfmi
Copy link
Collaborator Author

failfmi commented May 27, 2024

Current existing issue is mismatching header state root between block execution and validate_block. It might be related to mismatching host trie and runtime trie implementation

@failfmi failfmi marked this pull request as ready for review June 14, 2024 13:55
@failfmi failfmi merged commit c9a9654 into develop Jun 14, 2024
4 of 6 checks passed
@failfmi failfmi deleted the feat/parachain-compatibility branch June 14, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

parachain compatibility
2 participants