fix: resolve non-relative imports being evaluated as a potential rela…

…tive import This both conflicted with the use of baseUrl absolute imports and was in general a bug the resolution logic. Resolves #16
Limegrass · Apr 17, 2024 · 3512285 · 3512285
1 parent 44445f0
commit 3512285
Show file tree

Hide file tree

Showing 2 changed files with 121 additions and 0 deletions.
diff --git a/src/rules/import-alias.ts b/src/rules/import-alias.ts
@@ -24,6 +24,12 @@ function isPermittedRelativeImport(
     filepath: string,
     projectBaseDir: string
 ) {
+    const isRelativeImport =
+        importModuleName.length > 0 && importModuleName[0] !== ".";
+    if (isRelativeImport) {
+        return false;
+    }
+
     const importParts = importModuleName.split("/");
     const relativeDepth = importParts.filter(
         (moduleNamePart) => moduleNamePart === ".."

diff --git a/tests/rules/import-alias.test.ts b/tests/rules/import-alias.test.ts
@@ -451,6 +451,25 @@ function runTests(platform: "win32" | "posix") {
                 ],
                 filename: "src/foo/index.ts",
             },
+
+            // doesn't conflict with relativeImportOverrides
+            {
+                code: `export * from "src/potato";`,
+                errors: 1,
+                options: [
+                    {
+                        isAllowBaseUrlResolvedImport: false,
+                        relativeImportOverrides: [
+                            {
+                                path: ".",
+                                depth: 0,
+                            },
+                        ],
+                    },
+                ],
+                filename: "src/rules/test.ts",
+                output: `export * from "#src/potato";`,
+            },
         ],
     });
 
@@ -822,6 +841,25 @@ function runTests(platform: "win32" | "posix") {
                 ],
                 filename: "src/foo/index.ts",
             },
+
+            // doesn't conflict with relativeImportOverrides
+            {
+                code: `export { Potato } from "src/potato";`,
+                errors: 1,
+                options: [
+                    {
+                        isAllowBaseUrlResolvedImport: false,
+                        relativeImportOverrides: [
+                            {
+                                path: ".",
+                                depth: 0,
+                            },
+                        ],
+                    },
+                ],
+                filename: "src/rules/test.ts",
+                output: `export { Potato } from "#src/potato";`,
+            },
         ],
     });
 
@@ -1183,6 +1221,25 @@ function runTests(platform: "win32" | "posix") {
                 ],
                 filename: "src/foo/index.ts",
             },
+
+            // doesn't conflict with relativeImportOverrides
+            {
+                code: `import { Potato } from "src/potato";`,
+                errors: 1,
+                options: [
+                    {
+                        isAllowBaseUrlResolvedImport: false,
+                        relativeImportOverrides: [
+                            {
+                                path: ".",
+                                depth: 0,
+                            },
+                        ],
+                    },
+                ],
+                filename: "src/rules/test.ts",
+                output: `import { Potato } from "#src/potato";`,
+            },
         ],
     });
 
@@ -1544,6 +1601,25 @@ function runTests(platform: "win32" | "posix") {
                     ],
                     filename: "src/foo/index.ts",
                 },
+
+                // doesn't conflict with relativeImportOverrides
+                {
+                    code: `require("src/potato");`,
+                    errors: 1,
+                    options: [
+                        {
+                            isAllowBaseUrlResolvedImport: false,
+                            relativeImportOverrides: [
+                                {
+                                    path: ".",
+                                    depth: 0,
+                                },
+                            ],
+                        },
+                    ],
+                    filename: "src/rules/test.ts",
+                    output: `require("#src/potato");`,
+                },
             ],
         });
 
@@ -1900,6 +1976,25 @@ function runTests(platform: "win32" | "posix") {
                     ],
                     filename: "src/foo/index.ts",
                 },
+
+                // doesn't conflict with relativeImportOverrides
+                {
+                    code: `jest.mock("src/potato");`,
+                    errors: 1,
+                    options: [
+                        {
+                            isAllowBaseUrlResolvedImport: false,
+                            relativeImportOverrides: [
+                                {
+                                    path: ".",
+                                    depth: 0,
+                                },
+                            ],
+                        },
+                    ],
+                    filename: "src/rules/test.ts",
+                    output: `jest.mock("#src/potato");`,
+                },
             ],
         });
 
@@ -2295,6 +2390,26 @@ function runTests(platform: "win32" | "posix") {
                         ],
                         filename: "src/foo/index.ts",
                     },
+
+                    // doesn't conflict with relativeImportOverrides
+                    {
+                        code: `potato("src/potato");`,
+                        errors: 1,
+                        options: [
+                            {
+                                aliasImportFunctions: ["potato"],
+                                isAllowBaseUrlResolvedImport: false,
+                                relativeImportOverrides: [
+                                    {
+                                        path: ".",
+                                        depth: 0,
+                                    },
+                                ],
+                            },
+                        ],
+                        filename: "src/rules/test.ts",
+                        output: `potato("#src/potato");`,
+                    },
                 ],
             }
         );