submit_for_testing: use qa_server_group and not _team#102
Open
roxell wants to merge 1 commit intoLinaro:masterfrom
Open
submit_for_testing: use qa_server_group and not _team#102roxell wants to merge 1 commit intoLinaro:masterfrom
roxell wants to merge 1 commit intoLinaro:masterfrom
Conversation
Contributor
|
IMHO group and team tare the same thing in this context. |
Contributor
|
The only failure in testing is on python file formatting. Please run black and commit changes. This should fix the sanity job. |
Contributor
|
I think we should preserve backward compatibility. So both --qa-server-team and --qa-server-group should set the same variable. Later we'll need a new patch that will throw an exception when someone tries to use --qa-server-team. |
It is a group setting on the qa-reports web page and not a team. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Contributor
|
I think this looks good, but since we're deprecating the use of the option, can we log or print a warning when the argument is set? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a group setting on the qa-reports web page and not a team.
Signed-off-by: Anders Roxell anders.roxell@linaro.org