Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] #172 popup #173

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[feat] #172 popup #173

wants to merge 3 commits into from

Conversation

leeseokchan00
Copy link

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • ํŒ์—… ๋„์šฐ๊ธฐ(๋งํฌ ์ด๋™, ์ผ์ฃผ์ผ ๋ณด์ง€ ์•Š๊ธฐ)

๐ŸŒฑ PR ํฌ์ธํŠธ

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

์Šคํฌ๋ฆฐ์ƒท
ํŒŒ์ผ์ฒจ๋ถ€๋ฐ”๋žŒ
Screen_recording_20240930_200536.mp4

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

@leeseokchan00 leeseokchan00 added โญ [FEAT] ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ๊ตฌํ˜„ ์„์ฐฌ ์ด์„์ฐฌ labels Sep 30, 2024
@leeseokchan00 leeseokchan00 self-assigned this Sep 30, 2024
Copy link
Contributor

@lsakee lsakee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUTE

Comment on lines +15 to +18
internal fun ResponsePopupInvisibleDto.toCoreModel() = PopupInvisible(
popupId = popupId,
popupHideUntil = hideUntil,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal ์„ ์“ฐ์‹  ์ด์œ ๊ฐ€ ์žˆ๋‚˜์šฅ!?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋งคํ•‘ํ•จ์ˆ˜๋‹ˆ๊นŒ data-remote ๋ชจ๋“ˆ ์•ˆ์—์„œ๋งŒ ์‚ฌ์šฉ๋˜๊ฒŒ ํ•˜๋ ค๊ณ  ํ–ˆ์Šต๋‹ˆ๋‹ค

Comment on lines 15 to +18
val url: String = "",
val categoryId: Long? = 0,
val categoryName: String? = "์ „์ฒด ํด๋ฆฝ",
val popupList: List<PopupInfo> = emptyList(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emptyList๋ฅผ ์“ด ์ด์œ ๊ฐ€ ์žˆ๋‚˜์š”?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ธฐ๋ณธ๊ฐ’์„ null๋กœ ๋‘๊ฒŒ๋˜๋ฉด state๋ฅผ ํ™•์ธํ•  ๋•Œ๋งˆ๋‹ค null ์ฒดํฌ๋ฅผ ํ•ด์•ผํ•˜๊ธฐ ๋•Œ๋ฌธ์—, emtpyList๋กœ ๋‘์–ด popupList๊ฐ€ ์ดˆ๊ธฐํ™” ๋˜์ง€ ์•Š์•˜๋”๋ผ๊ณ  ์ ‘๊ทผ์ด ๊ฐ€๋Šฅํ•˜๊ฒŒ ํ•ด์•ผํ•œ๋‹ค๊ณ  ์ƒ๊ฐํ–ˆ์Šต๋‹ˆ๋‹ค์ž‰.

Comment on lines +140 to +146
fun checkPopupDate(activeStartDate: String, activeEndDate: String): Boolean {
val dateFormat = SimpleDateFormat("yyyy-MM-dd", Locale.getDefault())
val today = Calendar.getInstance().time
val startDate = dateFormat.parse(activeStartDate)
val endDate = dateFormat.parse(activeEndDate)
return today.after(startDate) && today.before(endDate) || today == startDate || today == endDate
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์žฌ์‚ฌ์šฉ์„ฑ ์žˆ์–ด ๋ณด์ด๋„ค์š”

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋งŒ๋“ค๋•Œ๋ถ€ํ„ฐ ๊ณ ๋ฏผ์ด์—ˆ๋Š”๋ฐ, ์ด๋Ÿฐ ์กฐ๊ฑด๊ฒ€์‚ฌ๋Š” usecase๋กœ ๋“ค์–ด๊ฐ€์•ผ ๋˜๋‚˜์š”?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โญ [FEAT] ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ๊ตฌํ˜„ ์„์ฐฌ ์ด์„์ฐฌ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] ์„ค๋ฌธ์กฐ์‚ฌ ์•Œ๋ŸฌํŠธ
2 participants