Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable multiprocessing for spectral, wavelet and cross-wavelet analysis #637

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

khider
Copy link
Member

@khider khider commented Jan 9, 2025

Enable multiprocessing for the significance test. Speed up is about x6 on Mac M3.

  1. Functions that were added at the top of modules are helper function that NEED to be outside a class to function. They have an _ at the beginning so they are set to private and won't appear anywhere.
  2. The Series class needs to be imported inside the functions for coherence for pickling issues. Do not remove the line
  3. For coherence, dill was necessary (Series is not pickable apparently).
  4. General clean up to the code base since I was at it.

@khider khider requested a review from CommonClimate January 9, 2025 02:04
Copy link
Collaborator

@CommonClimate CommonClimate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust that this all works!

Looks like several new packages are being used, but I don't see changes to environment.yml and setup.py. Please update to make sure it plays nice with the rest of the package.

@khider
Copy link
Member Author

khider commented Jan 13, 2025

I added dill (only package that is not from Python itself) and tried to fix some of the docs issues as well.

Copy link
Collaborator

@CommonClimate CommonClimate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green light!

@CommonClimate CommonClimate merged commit b7cb5fe into master Jan 28, 2025
1 check passed
@CommonClimate CommonClimate deleted the multiprocessing branch January 28, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants