Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Align code snippets #1764

Merged
merged 8 commits into from
Aug 3, 2023
Merged

Align code snippets #1764

merged 8 commits into from
Aug 3, 2023

Conversation

Tschakki
Copy link
Contributor

What was the problem?

This PR resolves #1724

@Tschakki Tschakki self-assigned this Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #1764 (31d7ab0) into release/0.7.0 (659e069) will decrease coverage by 1.55%.
Report is 41 commits behind head on release/0.7.0.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/0.7.0    #1764      +/-   ##
=================================================
- Coverage          65.95%   64.41%   -1.55%     
=================================================
  Files                276      285       +9     
  Lines               4433     4887     +454     
  Branches             786      865      +79     
=================================================
+ Hits                2924     3148     +224     
- Misses              1509     1739     +230     

see 20 files with indirect coverage changes

@Tschakki Tschakki marked this pull request as ready for review July 27, 2023 10:52
Copy link
Contributor

@TalhaMaliktz TalhaMaliktz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Tschakki and others added 2 commits July 28, 2023 12:27
Co-authored-by: Muhammad Talha <13951043+TalhaMaliktz@users.noreply.github.com>
Copy link
Contributor

@TalhaMaliktz TalhaMaliktz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just a minor change! rest LGTM

docs/antora/modules/ROOT/pages/setup/docker.adoc Outdated Show resolved Hide resolved
docs/antora/modules/ROOT/pages/setup/docker.adoc Outdated Show resolved Hide resolved
docs/antora/modules/ROOT/pages/setup/docker.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@chris529 chris529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@sameersubudhi sameersubudhi merged commit 122e722 into release/0.7.0 Aug 3, 2023
7 of 8 checks passed
@sameersubudhi sameersubudhi deleted the 1724-align-code-snippets branch August 3, 2023 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants