LF-4718: fix web deploy tsc error

[antsgar]

Description

Fixes tsc error that causes web deploy fail after merging TS PR.

Jira link:

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Passes test case
• UI components visually reviewed on desktop view
• UI components visually reviewed on mobile view
• Other (please explain)

Checklist:

• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• The precommit and linting ran successfully
• I have added or updated language tags for text that's part of the UI
• I have added "MISSING" for all new language tags to languages I don't speak
• I have added the GNU General Public License to all new files

[kathyavini]

<MeatballsMenu /> looks good -- isn't erroring for me anymore -- but I still see an IDE error and pnpm build crash on <FileSizeExceedModal /> -- do you see that one?

src/components/Modals/FileSizeExceedModal/index.tsx:21:7 - error TS2322: Type 'string | number | boolean | object | TFunctionDetailedResult<string> | (string | object)[] | ReactElement<any, string | JSXElementConstructor<any>> | Iterable<...> | ReactPortal | null | undefined' is not assignable to type 'NonNullable<ReactNodeLike>'.
  Type 'undefined' is not assignable to type 'NonNullable<ReactNodeLike>'.

21       title={t(`FILE_SIZE_MODAL.TITLE`)}
         ~~~~~

  src/components/Modals/ModalComponent/v2/index.jsx:75:3
    75   title: PropTypes.node.isRequired || PropTypes.string.isRequired,
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    The expected type comes from property 'title' which is declared here on type 'IntrinsicAttributes & Pick<{ title: any; titleClassName: any; icon: any; contents: any; dismissModal: any; buttonGroup: any; children: any; warning: any; error: any; tooltipContent: any; className?: string | undefined; }, "className"> & Pick<...> & Pick<...>'

In order to see any errors at all I had to do a fresh node_modules install though on integration. Probably it was a version bump in some @types package or other (@types/react or maybe a MUI thing?) that introduced this error, right?

[kathyavini]

This solves the issue for me in that file, but I get a different tsc error in components/Drawer on build 😂

src/components/Drawer/index.tsx:69:7 - error TS2322: Type 'NonNullable<ReactNode>' is not assignable to type 'string | undefined'.
  Type 'number' is not assignable to type 'string'.

69       title={title}
         ~~~~~


Found 1 error in src/components/Drawer/index.tsx:69

I appreciate that you are actually solving the errors, though, I would have so totally used // @ts-ignore 😅

[kathyavini]

❤️

[SayakaOno]

Worked for me too, thank you!