Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-4722b Fix start:prod path to match container structure #3683

Conversation

kathyavini
Copy link
Collaborator

@kathyavini kathyavini commented Feb 6, 2025

Description

This is the follow-up to the PR and the solution was tested live (successfully) during tech daily Feb 6

When merging that PR we saw that the /dist folder was successfully built within the container image. The issue was that tsc copies the directory structure of its source, and in the Docker image the path has been set up as /app/src/server.js instead of api/src/server.js. This PR just changes the start:prod script path to match this.

As a side effect you cannot use npm run start:prod locally after this change but as it was meant to be used in hosted container I don't see this as an issue.

@Duncan-Brain I did not delete the npm run start script here because it is used by the Cypress tests.

Jira link: https://lite-farm.atlassian.net/browse/LF-4722

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

We have already tested the change on the droplet directly and it worked to get the backend container up and running again.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@kathyavini kathyavini added the bug Something isn't working label Feb 6, 2025
@kathyavini kathyavini self-assigned this Feb 6, 2025
@kathyavini kathyavini requested review from a team as code owners February 6, 2025 19:00
@kathyavini kathyavini requested review from antsgar and SayakaOno and removed request for a team February 6, 2025 19:00
@kathyavini kathyavini added this pull request to the merge queue Feb 6, 2025
Merged via the queue into integration with commit 3e4c4df Feb 6, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants