Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup a workflow to run on push #5

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Setup a workflow to run on push #5

wants to merge 24 commits into from

Conversation

zacck-zz
Copy link
Member

@zacck-zz zacck-zz commented Jul 8, 2020 •
edited by Pancakem
Loading

Changes Proposed

Fixes #2

  • Add a github workflow to run on push
  • Make sure code compiles on push
  • Run tests on pull request
  • Build executable on merge to dev and ship executable as staging version
  • Build executable on merge to prod and ship executable as current version

NB
Executables should be shipped as images containing only the executable to our private registry

@zacck-zz
Copy link
Member Author

zacck-zz commented Jul 8, 2020

@Pancakem please help @omanimo determine what to run to ensure that the code compiles

@zacck-zz zacck-zz requested a review from Pancakem July 8, 2020 10:56
zacck-zz
zacck-zz commented Jul 9, 2020
View reviewed changes
.github/workflows/push.yml Outdated
@@ -18,7 +18,6 @@ jobs:
python -m pip install --upgrade pip
pip install -r requirements.txt


compile:
runs-on: windows-latest
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omanimo you want to use a matrix here, I run macos, marvin runs fedora and the server runs alpine ensure it compiles on all of those please

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted @zacck. Let me get on it.

Pancakem
Pancakem reviewed Jul 9, 2020
View reviewed changes
Copy link
Contributor

@Pancakem Pancakem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.
I am working on adding unit tests, to be run on a pull request.

@Pancakem
Copy link
Contributor

@omanimo I added a test to see, confirm the parser works. The test is run by python manage.py test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omanimo omanimo omanimo left review comments

@Pancakem Pancakem Pancakem left review comments

Assignees

@zacck-zz zacck-zz

@omanimo omanimo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup CI/CD for the project
4 participants
@zacck-zz @Pancakem @omanimo @zacck