Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the Linker, Ranker, Recogniser and Pipeline #282

Open
wants to merge 138 commits into
base: dev
Choose a base branch
from
Open

Refactor the Linker, Ranker, Recogniser and Pipeline #282

wants to merge 138 commits into from

Conversation

thobson88
Copy link
Collaborator

@thobson88 thobson88 commented Dec 15, 2024 •
edited
Loading

Closes #276.

Major refactor. The main changes are:

  • new subclass structure in the Recogniser, Ranker & Linker (and common load and run interface)
  • new dataclasses representing data structures throughout the pipeline: Mention, Sentence, Candidates, Predictions, etc.
  • simplified Pipeline class, with all business logic moved into the Linker

@thobson88
Ignore .DS_Store files
00a3607
@thobson88
Refactor linking methods as Linker subclasses
a3c8c7a 
All tests not marked as 'deezy' are passing
@thobson88
Add RelDisamb Linker subclass & fix tests
a114f2c
@thobson88
Move rel_params to the RelDisambLinker class
769488e
@thobson88
Remove superfluous return value
5422243
@thobson88
Refactor Ranker into subclasses
e8282fb
@thobson88
Modify Ranker class hierarchy; fix unit tests
7a1e7a5
@thobson88
Fix method_name in DeezyMatchRanker
b42f6e5
@thobson88
Fix integration tests
3bf6fa6
@thobson88
Move train method to DeezyMatchRanker
936cc21
@thobson88
Fix docstrings
5219598
@thobson88
Move deezy-specific code to Ranker subclass
c94c166
@thobson88
Update docstrings
c3cf63b
@thobson88
Refactor the Recogniser class
daf97ad
@thobson88
Simplify variable names & rename module to avoid clash
b31d07e
@thobson88
Simplify Pipeline constructor
2e7d53d
@thobson88
Remove superfluous return value
dc97af8
@thobson88
Add Pipeline constructor unit test
ee02a65
@thobson88
Remove inconsistency in treating place_wqid
e13743f
@thobson88
Remove superfluous return value
d28f5ad
@thobson88
Add dataclasses to represent ranking candidates
7c39f6d
@thobson88
Integrate dataclasses into the Ranker
e42192d
@thobson88
Integrate dataclasses into Linker & Pipeline
2088beb
@thobson88
Add method return types
29de527
@thobson88
Move dataclasses to own module
1394718
@thobson88
Add new dataclasses for Ranker & Linker output
6d8fa19
@thobson88
Update dataclasses and integrate into Linker & Pipeline
34260f0
@thobson88
Reorder dataclasses module
004bd53
@thobson88
Rename Ranker cache & load method; Edit docstrings
d54392a
@thobson88
Replace Ranker method_name() with class attribute
ffe8a59
@thobson88 thobson88 mentioned this pull request Jan 7, 2025
Merged
@thobson88
Copy link
Collaborator Author

thobson88 commented Jan 8, 2025 •
edited
Loading

TODO:

  • attach lat-lon data for all predictions (i.e. pipeline outputs), not only the ones linked by distance
  • update README

@thobson88 thobson88 mentioned this pull request Jan 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwood-97 rwood-97 rwood-97 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor the Linker, Ranker, Recogniser and Pipeline
2 participants
@thobson88 @rwood-97