Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

fix: add exception handling to get amd gpu usage #405

Merged

Conversation

ReenigneArcher
Copy link
Member

Description

When first starting RetroArcher, the getCurrentUsage() method, may return an error initially. This PR adds a try/except block around it.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4826e9b) 72.88% compared to head (3377633) 72.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
- Coverage   72.88%   72.61%   -0.28%     
==========================================
  Files          10       10              
  Lines         793      796       +3     
==========================================
  Hits          578      578              
- Misses        215      218       +3     
Flag Coverage Δ
Linux-x64 70.97% <20.00%> (-0.27%) ⬇️
Windows-x64 71.23% <20.00%> (-0.27%) ⬇️
Windows-x86 71.23% <20.00%> (-0.27%) ⬇️
macOS-x64 71.48% <20.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pyra/hardware.py 78.26% <20.00%> (-1.49%) ⬇️

@ReenigneArcher ReenigneArcher force-pushed the fix-add-exception-handling-to-get-amd-gpu-usage branch from 0bb8d49 to 3377633 Compare January 19, 2024 01:10
@ReenigneArcher ReenigneArcher merged commit 7715f94 into master Jan 19, 2024
20 of 21 checks passed
@ReenigneArcher ReenigneArcher deleted the fix-add-exception-handling-to-get-amd-gpu-usage branch January 19, 2024 01:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant