Update LED control to use output instead of light#18
Open
MichaelMKKelly wants to merge 1 commit intoLocalBytes:mainfrom
Open
Update LED control to use output instead of light#18MichaelMKKelly wants to merge 1 commit intoLocalBytes:mainfrom
MichaelMKKelly wants to merge 1 commit intoLocalBytes:mainfrom
Conversation
Replaced 'light' commands with 'output' commands for LED control.
bobbinz
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the light component and instead drive the LED directly from the output component.
The light component in binary mode component is just a wrapper on the output component and as the light is not directly exposed anyway it brings no functionality by having it.
Whilst this change makes functionally no real difference, The light component itself is one of the heavier components so by removing it and driving the output directly there is a relatively big saving of both firmware flash size and also memory usage on the ESP.
This means increased breathing room for firmware size in the future and also increased stability from less memory usage. These benifits will matter more if people are adding extra functioanlity and need the breathing space.