Skip to content

Commit

Permalink
PreRelease clearnings
Browse files Browse the repository at this point in the history
  • Loading branch information
ninetor committed Feb 12, 2019
2 parents a253fb0 + 39a6ae2 commit 1230e05
Show file tree
Hide file tree
Showing 78 changed files with 1,444 additions and 3,806 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
CMakeCache.txt
CMakeFiles
Makefile
CMakeDoxyfile.in
compile_commands.json
moc_*
*.moc
Expand Down
19 changes: 12 additions & 7 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# Defines LocalCoin library target.
project( BitShares )
project( LocalCoin )
cmake_minimum_required( VERSION 2.8.12 )

set( BLOCKCHAIN_NAME "BitShares" )
set( BLOCKCHAIN_NAME "LocalCoin" )

set( CLI_CLIENT_EXECUTABLE_NAME graphene_client )
set( GUI_CLIENT_EXECUTABLE_NAME BitShares )
set( GUI_CLIENT_EXECUTABLE_NAME LocalCoin )
set( CUSTOM_URL_SCHEME "gcs" )
set( INSTALLER_APP_ID "68ad7005-8eee-49c9-95ce-9eed97e5b347" )

Expand Down Expand Up @@ -102,6 +102,11 @@ if( WIN32 )
SET(TCL_LIBS "${TCL_LIBS}${TCL_LIB_PATH}/${TCL_LIB_NAME}g${TCL_LIB_EXT}")
SET(TCL_LIBRARY ${TCL_LIBS})

find_package( CURL )
set(CURL_STATICLIB ON)
include_directories( ${CURL_INCLUDE_DIRS} )
link_directories( ${CURL_LIBRARIES} )

else( WIN32 ) # Apple AND Linux

if( APPLE )
Expand Down Expand Up @@ -177,15 +182,15 @@ set(CPACK_PACKAGE_VERSION "${CPACK_PACKAGE_VERSION_MAJOR}.${CPACK_PACKAGE_VERSIO
set(CPACK_PACKAGE_DESCRIPTION "A client for the LocalCoin network")
set(CPACK_PACKAGE_DESCRIPTION_SUMMARY "A client for the LocalCoin network")
set(CPACK_RESOURCE_FILE_LICENSE "${CMAKE_CURRENT_SOURCE_DIR}/LICENSE.md")
set(CPACK_PACKAGE_INSTALL_DIRECTORY "BitShares ${CPACK_PACKAGE_VERSION}")
set(CPACK_PACKAGE_INSTALL_DIRECTORY "LocalCoin ${CPACK_PACKAGE_VERSION}")

if(WIN32)
SET(CPACK_GENERATOR "ZIP;NSIS")
set(CPACK_PACKAGE_NAME "BitShares") # override above
set(CPACK_PACKAGE_NAME "LocalCoin") # override above
set(CPACK_NSIS_EXECUTABLES_DIRECTORY .)
set(CPACK_NSIS_PACKAGE_NAME "BitShares v${CPACK_PACKAGE_VERSION}")
set(CPACK_NSIS_PACKAGE_NAME "LocalCoin v${CPACK_PACKAGE_VERSION}")
set(CPACK_NSIS_DISPLAY_NAME "${CPACK_NSIS_PACKAGE_NAME}")
set(CPACK_NSIS_DEFINES " !define MUI_STARTMENUPAGE_DEFAULTFOLDER \\\"BitShares\\\"")
set(CPACK_NSIS_DEFINES " !define MUI_STARTMENUPAGE_DEFAULTFOLDER \\\"LocalCoin\\\"")
# it seems like windows zip files usually don't have a single directory inside them, unix tgz frequently do
SET(CPACK_INCLUDE_TOPLEVEL_DIRECTORY 0)

Expand Down
26 changes: 4 additions & 22 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,6 @@
LocalCoin Core
LocalCoin Core - MasterNodes
==============

[Build Status](https://travis-ci.org/LocalCoinIS/LocalCoin-core/branches):

`master` | `develop` | `hardfork` | `testnet` | `localcoin-fc`
--- | --- | --- | --- | ---
[![](https://travis-ci.org/LocalCoinIS/LocalCoin-core.svg?branch=master)](https://travis-ci.org/LocalCoinIS/LocalCoin-core) | [![](https://travis-ci.org/LocalCoinIS/LocalCoin-core.svg?branch=develop)](https://travis-ci.org/LocalCoinIS/LocalCoin-core) | [![](https://travis-ci.org/LocalCoinIS/LocalCoin-core.svg?branch=hardfork)](https://travis-ci.org/LocalCoinIS/LocalCoin-core) | [![](https://travis-ci.org/LocalCoinIS/LocalCoin-core.svg?branch=testnet)](https://travis-ci.org/LocalCoinIS/LocalCoin-core) | [![](https://travis-ci.org/LocalCoinIS/LocalCoin-fc.svg?branch=master)](https://travis-ci.org/LocalCoinIS/LocalCoin-fc)


* [Getting Started](#getting-started)
* [Support](#support)
* [Using the API](#using-the-api)
Expand All @@ -18,7 +11,7 @@ LocalCoin Core
LocalCoin Core is the LocalCoin blockchain implementation and command-line interface.
The web wallet is [LocalCoin UI](https://github.com/LocalCoinIS/LocalCoin-ui).

Visit [localcoin.org](https://localcoin.org/) to learn about LocalCoin and join the community at [localcoinTalk.org](https://localcointalk.org/).
Visit [localcoin.is](https://localcoin.is/) to learn about LocalCoin.

**NOTE:** The official LocalCoin git repository location, default branch, and submodule remotes were recently changed. Existing
repositories can be updated with the following steps:
Expand All @@ -33,7 +26,7 @@ repositories can be updated with the following steps:
Getting Started
---------------
Build instructions and additional documentation are available in the
[wiki](https://github.com/LocalCoinIS/LocalCoin-core/wiki).
[wiki](https://dev.localcoin.is).

We recommend building on Ubuntu 16.04 LTS, and the build dependencies may be installed with:

Expand Down Expand Up @@ -88,14 +81,10 @@ Use `help` to see all available wallet commands. Source definition and listing o

Support
-------
Technical support is available in the [localcoinTalk technical support subforum](https://localcointalk.org/index.php?board=45.0).

LocalCoin Core bugs can be reported directly to the [issue tracker](https://github.com/LocalCoinIS/LocalCoin-core/issues).

LocalCoin UI bugs should be reported to the [UI issue tracker](https://github.com/LocalCoinIS/LocalCoin-ui/issues)

Up to date online Doxygen documentation can be found at [Doxygen](https://localcoin.org/doxygen/hierarchy.html)

Using the API
-------------

Expand Down Expand Up @@ -160,13 +149,6 @@ With the above configuration, here is an example of how to call `add_node` from

Note, the call to `network_node` is necessary to obtain the correct API identifier for the network API. It is not guaranteed that the network API identifier will always be `2`.

Since the `network_node` API requires login, it is only accessible over the websocket RPC. Our `doxygen` documentation contains the most up-to-date information
about API's for the [witness node](https://localcoin.github.io/doxygen/namespacegraphene_1_1app.html) and the
[wallet](https://localcoin.github.io/doxygen/classgraphene_1_1wallet_1_1wallet__api.html).
If you want information which is not available from an API, it might be available
from the [database](https://localcoin.github.io/doxygen/classgraphene_1_1chain_1_1database.html);
it is fairly simple to write API methods to expose database methods.

FAQ
---

Expand Down Expand Up @@ -207,7 +189,7 @@ FAQ

The second number specifies the *type*. The type of the object determines what fields it has. For a
complete list of type ID's, see `enum object_type` and `enum impl_object_type` in
[types.hpp](https://github.com/LocalCoinIS/LocalCoin-2/blob/localcoin/libraries/chain/include/graphene/chain/protocol/types.hpp).
[types.hpp](https://github.com/LocalCoinIS/LocalCoin-core/blob/master/libraries/chain/include/graphene/chain/protocol/types.hpp).

The third number specifies the *instance*. The instance of the object is different for each individual
object.
Expand Down
17 changes: 0 additions & 17 deletions check_unique_assets.php

This file was deleted.

31 changes: 0 additions & 31 deletions create_account.php

This file was deleted.

2 changes: 1 addition & 1 deletion docs
Submodule docs updated from bd792d to 008cd6
11 changes: 11 additions & 0 deletions genesis.json
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,16 @@
],
[
46, {}
],
[
47, {
"fee": 1000000
}
],
[
48, {
"fee" : 100000
}
]
],
"scale": 10000
Expand All @@ -269,6 +279,7 @@
"cashback_vesting_threshold": 10000000,
"count_non_member_votes": true,
"allow_non_member_whitelists": false,
"activenode_pay_per_block": 6500,
"witness_pay_per_block": 65000,
"worker_budget_per_day": "30000000000",
"max_predicate_opcode": 1,
Expand Down
22 changes: 0 additions & 22 deletions import_balances.php

This file was deleted.

29 changes: 0 additions & 29 deletions issue_assets.php

This file was deleted.

47 changes: 0 additions & 47 deletions issue_assets_for_test.php

This file was deleted.

14 changes: 10 additions & 4 deletions libraries/app/application.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ namespace graphene { namespace app { namespace detail {

void application_impl::reset_p2p_node(const fc::path& data_dir)
{ try {
_p2p_network = std::make_shared<net::node>("BitShares Reference Implementation");
_p2p_network = std::make_shared<net::node>("LocalCoin Reference Implementation");

_p2p_network->load_configuration(data_dir / "p2p");
_p2p_network->set_node_delegate(this);
Expand Down Expand Up @@ -164,8 +164,11 @@ void application_impl::reset_p2p_node(const fc::path& data_dir)
else
{
// https://bitsharestalk.org/index.php/topic,23715.0.html
vector<string> seeds = {
};
vector<string> seeds = {
"moscow.localcoin.is:11010" // Moscow (Russia)
"ru.localcoin.is:11010" // Russia
"helsinki.localcoin.is:11010" // Helsinki (Finland)
};
for( const string& endpoint_string : seeds )
{
try {
Expand Down Expand Up @@ -500,6 +503,9 @@ bool application_impl::handle_block(const graphene::net::block_message& blk_msg,
// the block was accepted, so we now know all of the transactions contained in the block
if (!sync_mode)
{
_chain_db->notify_new_block_applied( blk_msg.block ); //emit


// if we're not in sync mode, there's a chance we will be seeing some transactions
// included in blocks before we see the free-floating transaction itself. If that
// happens, there's no reason to fetch the transactions, so construct a list of the
Expand Down Expand Up @@ -542,7 +548,6 @@ void application_impl::handle_transaction(const graphene::net::trx_message& tran
last_call = now;
trx_count = 0;
}

_chain_db->push_transaction( transaction_message.trx );
} FC_CAPTURE_AND_RETHROW( (transaction_message) ) }

Expand Down Expand Up @@ -976,6 +981,7 @@ void application::initialize(const fc::path& data_dir, const boost::program_opti
else
{
wanted.push_back("witness");
wanted.push_back("activenode");
wanted.push_back("account_history");
wanted.push_back("market_history");
wanted.push_back("grouped_orders");
Expand Down
Loading

0 comments on commit 1230e05

Please sign in to comment.