Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

281 make rcon password editable even when its hidden #317

Merged
merged 3 commits into from
Jul 23, 2023

Conversation

jhuang38
Copy link
Contributor

Description

Aim was to make password field editable immediately without clicking hide/show icon, also made password field editable and savable while hidden.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Note: make sure your files are formatted with rust-analyzer

@jhuang38 jhuang38 requested a review from Ynng July 23, 2023 20:33
@netlify
Copy link

netlify bot commented Jul 23, 2023

Deploy Preview for lodestone-storybook ready!

Name Link
🔨 Latest commit 0e3fcd9
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-storybook/deploys/64bd8e93219fe200086788f1
😎 Deploy Preview https://deploy-preview-317--lodestone-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 23, 2023

Deploy Preview for lodestone-dashboard ready!

Name Link
🔨 Latest commit 0e3fcd9
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-dashboard/deploys/64bd8e93ce3e9a0008c6c700
😎 Deploy Preview https://deploy-preview-317--lodestone-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! that was easier then expected

@jhuang38 jhuang38 merged commit bc82947 into dev Jul 23, 2023
12 checks passed
@jhuang38 jhuang38 deleted the 281-make-rcon-password-editable-even-when-its-hidden branch August 1, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants