Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add thanking modal on first launch of core #322

Merged
merged 3 commits into from
Aug 12, 2023
Merged

add thanking modal on first launch of core #322

merged 3 commits into from
Aug 12, 2023

Conversation

seliayeu
Copy link
Contributor

added modal to thank lodestone beta users on first launch of core

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for lodestone-dashboard ready!

Name Link
🔨 Latest commit a625b7b
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-dashboard/deploys/64ce8d2407267500089f40cb
😎 Deploy Preview https://deploy-preview-322--lodestone-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@seliayeu seliayeu requested a review from CheatCod July 31, 2023 00:22
@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for lodestone-storybook ready!

Name Link
🔨 Latest commit a625b7b
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-storybook/deploys/64ce8d24ffc1b20008c4be43
😎 Deploy Preview https://deploy-preview-322--lodestone-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@seliayeu seliayeu requested review from Ynng and removed request for CheatCod August 3, 2023 02:13
@Ynng
Copy link
Member

Ynng commented Aug 3, 2023

where are we checking for "beta" versions? I think with the current implementation the modal will pop up on every new version, even stable versions

@seliayeu seliayeu linked an issue Aug 5, 2023 that may be closed by this pull request
Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, works for me!

@seliayeu seliayeu merged commit 04d4023 into dev Aug 12, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thank you pop up for prerelease version
2 participants