Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard docker path routing #423

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sentanos
Copy link

@sentanos sentanos commented Oct 15, 2024

Description

The current docker image does not support any path routing. If you go to any
path other than the root, it 404s.

For example, if you go to a page other than the index and then refresh, it will
404.

This adds basic routing to fall back to index.html if a file isn't found. This
is already properly handled by the built index.html such that an invalid path
will show a proper 404 page (rather than the nginx 404 page).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Note: make sure your files are formatted with rust-analyzer

@sentanos sentanos changed the title Dashboard docker dynamic routing Dashboard docker path routing Oct 15, 2024
Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for lodestone-dashboard canceled.

Name Link
🔨 Latest commit 9e2f8fb
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-dashboard/deploys/670e138959234a0008ddb46d

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for lodestone-storybook ready!

Name Link
🔨 Latest commit 9e2f8fb
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-storybook/deploys/670e13891afff70008c05f3c
😎 Deploy Preview https://deploy-preview-423--lodestone-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sentanos
Copy link
Author

An alternative would be #422, but I considered this a less obtrusive change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant