new RegistrationRequest model #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web3nerdy
reviewed
Sep 4, 2025
Contributor
There was a problem hiding this comment.
We have 2 kinds of duplicated address mixin for now.
I think we have to make it one as you created - AddressValidatorMixin.
- remove
VaultAddressValidatorMixinand replace withAddressValidatorMixin - change the fileld name of
vault_addresstoaddressaccordingly - change the filed name of
vault_nametonameas well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Improve data typing and validation for Yield Analysis SDK
This PR introduces enhancements to the data typing and validation mechanisms within the Yield Analysis SDK. Key changes include:
yield_analysis_sdk/type.pyto ensure better consistency and accuracy across the SDK.yield_analysis_sdk/validators.pyto provide more robust and precise data validation, reducing potential errors and improving data integrity.These changes aim to improve the overall reliability, maintainability, and usability of the SDK by strengthening its foundational data structures and validation processes.