Removed TODOs. (#16)

Logitar · Apr 29, 2024 · 656a112 · 656a112
1 parent ed9d93c
commit 656a112
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 9 deletions.
diff --git a/backend/src/Logitar.Master.Application/Accounts/Commands/SignInCommandHandler.cs b/backend/src/Logitar.Master.Application/Accounts/Commands/SignInCommandHandler.cs
@@ -39,7 +39,6 @@ public SignInCommandHandler(IMessageService messageService, IOneTimePasswordServ
   public async Task<SignInCommandResult> Handle(SignInCommand command, CancellationToken cancellationToken)
   {
     SignInPayload payload = command.Payload;
-    // TODO(fpion): validate payload
 
     if (payload.Credentials != null)
     {

diff --git a/backend/src/Logitar.Master.Contracts/Accounts/CompleteProfilePayload.cs b/backend/src/Logitar.Master.Contracts/Accounts/CompleteProfilePayload.cs
@@ -7,7 +7,7 @@ public record CompleteProfilePayload : SaveProfilePayload
   public string? Password { get; set; }
   public MultiFactorAuthenticationMode MultiFactorAuthenticationMode { get; set; }
 
-  public string? PhoneNumber { get; set; } // TODO(fpion): CountryCode? IsVerified?
+  public string? PhoneNumber { get; set; }
 
   public CompleteProfilePayload() : this(string.Empty, string.Empty, string.Empty, string.Empty, string.Empty)
   {

diff --git a/backend/src/Logitar.Master.Contracts/Accounts/SaveProfilePayload.cs b/backend/src/Logitar.Master.Contracts/Accounts/SaveProfilePayload.cs
@@ -2,11 +2,6 @@
 
 public record SaveProfilePayload
 {
-  // TODO(fpion): change Password
-  // TODO(fpion): change Email/UniqueName
-  // TODO(fpion): change Phone
-  // TODO(fpion): change MultiFactorAuthenticationMode
-
   public string FirstName { get; set; }
   public string? MiddleName { get; set; }
   public string LastName { get; set; }

diff --git a/backend/src/Logitar.Master.Infrastructure/IdentityServices/UserService.cs b/backend/src/Logitar.Master.Infrastructure/IdentityServices/UserService.cs
@@ -69,7 +69,7 @@ public async Task<User> SaveProfileAsync(Guid userId, SaveProfilePayload profile
       }
       if (completedProfile.PhoneNumber != null)
       {
-        payload.Phone = new Modification<PhonePayload>(new PhonePayload(countryCode: null, completedProfile.PhoneNumber, extension: null, isVerified: false)); // TODO(fpion): CountryCode? IsVerified?
+        payload.Phone = new Modification<PhonePayload>(new PhonePayload(countryCode: null, completedProfile.PhoneNumber, extension: null, isVerified: false));
       }
       payload.CompleteProfile();
       payload.SetMultiFactorAuthenticationMode(completedProfile.MultiFactorAuthenticationMode);

diff --git a/backend/src/Logitar.Master/Startup.cs b/backend/src/Logitar.Master/Startup.cs
@@ -83,7 +83,7 @@ public override void ConfigureServices(IServiceCollection services)
         throw new DatabaseProviderNotSupportedException(databaseProvider);
     }
 
-    services.AddLogitarPortalClient(_configuration); // TODO(fpion): seeding
+    services.AddLogitarPortalClient(_configuration);
     services.AddTransient<IRequestPipeline, HttpRequestPipeline>();
   }