Release candidate FSC 2.0.0 #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since a Group can only be used in a single network, it makes sense to add this information to the rules & restrictions of a Group. This makes it easier for users to understand where a Group is located. Eg. public internet or DigiNetwerk. When this MR is merged, the Digikoppeling Koppelvlakstandaard REST-API needs to be updated with the network being used. See https://gitdocumentatie.logius.nl/publicatie/dk/restapi/#federated-service-connectivity-standaard-fsc
Add Regulated Area to readme
The column is listing grant types, not hash types.
…parate codes Since it is not clear if the receiver should check if the receiver or the submitter should be part of the Contract. This becomes more clear if we introduce two error codes instead of one: 1. `ERROR_CODE_SUBMITTING_PEER_NOT_PART_OF_CONTRACT` 2. `ERROR_CODE_RECEIVING_PEER_NOT_PART_OF_CONTRACT`
Master to develop
Fix incorrect table heading
Sync with master
Add Network-decision to the list when defining a Group
Replace error code ERROR_CODE_PEER_NOT_PART_OF_CONTRACT with two separate codes.
Dan wordt hij correct meegenomen in de publicatie.
…#25) * add properties object to grants Each Grant can contain an optional properties object that can be used to provide extra information. This makes it easier to extend FSC with additional functionality. * update hash creation instructions Use RFC8785 JSON Canonicalization Scheme to create consistent JSON objects. Because the objects are consistent they create consitent hashes. By using the RFC FSC core no longer needs to define how the JSON objects should be handled to create consistent hashes. * Add details about the JSON format to the protocol section * Remove dots at end of the line for consistency * Remove duplicate details about the usage of JCS * Formatting * Add clarification about the allowed properties * update grant hash section make it more clear that the Canonical JSON should represented as a string * Fix ref --------- Co-authored-by: Ronald Koster <ronald.koster07@gmail.com> Co-authored-by: ndequeker <niels@nd-software.be> Co-authored-by: Stas Mironov <staspas@hotmail.com> Co-authored-by: Alexander Green <alexander.green@logius.nl>
Since we've decided to consolidate Group and Profile into 'Group', we should remove 'profile' everywhere. Initial PR: #3 Co-authored-by: ndequeker <niels@nd-software.be>
By including the FSC version in the contract it becomes possible to determine if a Manager is compatible with the contract This will help users with: - debugging - only accepting Contracts with an FSC version that the receiving Manager can comply with (eg. older versions) Co-authored-by: Ronald Koster <ronald.koster07@gmail.com>
* update the delegated connection diagrams The previous diagrams created some confusing because the submit contract step was not properly placed. And in the real world the Delegatee will most likely create the contract instead of the Delegator. * improve guiding texts of the diagrams --------- Co-authored-by: Ronald Koster <ronald.koster07@gmail.com>
* Add error code for unknown FSC version * The `fsc_version` property is required when submitting a Contract
Co-authored-by: Ronald Koster <ronald.koster07@gmail.com>
Hiermee worden automatisch `Status:` labels toegevoegd aan PRs als er activiteit op komt (openen, closen of een review).
* Ensure request / response bodies consistently use `content` for the Contract content. Instead of mixing `contract_content` and `content`. That is unnecessary and confusing. * Fix property name `algorithm` -> `hash_algorithm` for the Content hash section `algorithm` is not used. The correct property name from the OAS is `hash_algorithm`. * Remove redundant `contract.` prefix from the content hash section * Fix reference to wrong step number 13 in the content hash section * Fix property name `algorithm` -> `hash_algorithm` for the Grant hash section `algorithm` is not used. The correct property name from the OAS is `hash_algorithm`.
* allow outways based on domain name In a (Delegated) Service Connection Grant an Outway can be specified based on domain name. Previously only a public key thumbprint was allowed. An Outway must have the domain name specified as a Subject Alternative Name in its certificate to be allowed to request an access token. By allowing domain names Contracts won't have to be renewed when the Outway renews its certificate and rotates its keypair. * missing colon Co-authored-by: Niels Dequeker <niels@dqkr.be> --------- Co-authored-by: Ronald Koster <ronald.koster07@gmail.com> Co-authored-by: Stas Mironov <stas.mironov@logius.nl> Co-authored-by: Niels Dequeker <niels@dqkr.be>
* add properties to service listings Properties defined in the ServicePublicationGrant and DelegatedServicePublicationGrants should be included in the service listing. * included the delegated service publication grant in directory section The delegated service publication grant was missing in the behavior description of the Directory * github actions fix * remove space * rerun checks --------- Co-authored-by: Ronald Koster <ronald.koster07@gmail.com> Co-authored-by: Stas Mironov <stas.mironov@logius.nl> Co-authored-by: Stas M <staspas@hotmail.com>
github-actions
bot
added
the
Status: In bewerking
Use the same phrasing in the content hash and grant hash sections and reference the correct steps. Co-authored-by: Ronald Koster <ronald.koster07@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
ERROR_CODE_PEER_NOT_PART_OF_CONTRACTwith two se… by @Voles in Replace error codeERROR_CODE_PEER_NOT_PART_OF_CONTRACTwith two se… #34New Contributors