Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-751: Upgrade to Orchard Core 1.8 #120

Merged
merged 22 commits into from
Feb 21, 2024
Merged

OSOE-751: Upgrade to Orchard Core 1.8 #120

merged 22 commits into from
Feb 21, 2024

Conversation

Psichorex
Copy link
Contributor

@Psichorex Psichorex commented Jan 18, 2024

@Psichorex
Copy link
Contributor Author

@Piedone Something is broken in the VueJs module even on the latest dev branch. I got this error on my OSOE-751 branch so I went on to publish an alpha on the latest dev and the same error occured
https://github.com/Lombiq/Orchard-Vue.js/actions/runs/7933583361/job/21662668085

@Piedone
Copy link
Member

Piedone commented Feb 16, 2024

I don't know, @sarahelsaig? There's also something similar here: https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/actions/runs/7933803977

@sarahelsaig
Copy link
Member

@Psichorex I see the same error over and over again: Cannot find module '.nx/scripts/get-project-directory'

So it can't find this file. Considering that it's in the publish-nuget workflow, it may be trying to reference Lombiq.NodeJs.Extensions from submodule instead of NuGet, or trying to reference an older NuGet package?

@Piedone That's not similar, it says _rm:temp:styles (command rimraf "$DEST/_temp_") fails which is part of style compilation. I have never did anything with rimraf so I'm not sure what this means, could be some file system access problem.

@Piedone
Copy link
Member

Piedone commented Feb 16, 2024

Thank you!

@Psichorex
Copy link
Contributor Author

Awesome.. So this PR Lombiq/NodeJs-Extensions#78 introduced a new javascript file which is directly used by VueJs but there was no patch-minor release of this PR so in CI Nuget environment the javascript file which we are looking for doesn't exist but VueJs obviously want to use it. Buttpain again is that we intentionally wanted to skip NodeJsExtension release but now I will have to do one and also have to re-release everything that uses it.

@Psichorex Psichorex merged commit 00a8afc into dev Feb 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants