Ensure Stars Render in White #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed incorrect ordering of color components in `addColor` method within `ColorBuffer.kt`.
Updated `Star.kt` to set a default white color (`intArrayOf(255, 255, 255, 255)`) for stars. Refactored `CircleRenderer.kt` to align with the updated color handling logic using `IntArray`.
Closed
|
mehdi-hamirifou
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request standardizes the color handling for stars in the project, ensuring that they render with a default white color unless explicitly specified.
Changes
Star.kt:colorproperty to use anIntArrayrepresentation for RGBA with a default value ofintArrayOf(255, 255, 255, 255)(white).CircleRenderer.kt:IntArrayRGBA representation.StarsLoader.kt:Starinstances.