Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Prevent Feed from Displaying Logged-In User's Own Posts #284

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Fix: Prevent Feed from Displaying Logged-In User's Own Posts #284

merged 2 commits into from
Dec 18, 2024

Conversation

raniabbrk
Copy link
Contributor

Description

This PR addresses issue #240 to prevent the logged-in user's own posts from appearing in the feed.

Changes Implemented

  1. Test Refactoring in FeedScreenTest.kt:

    • Refactored tests to align with the new filtering logic.
    • Added the userMail parameter field in each post of the testPosts.
    • Updated the tests to simulate the logged-in user's email by setting the first post's email to match the logged-in user's email.
    • Ensured that all tests pass after these adjustments.

  2. Bug Fix in Filtering Logic:

    • Changed the filtering condition for initialNearbyPosts:
      • Previously, posts were filtered by comparing the logged-in user's username.
      • Now, posts are filtered using the logged-in user's email (userMail), ensuring more reliable matching and filtering.

Testing

  • Verified that all unit tests in FeedScreenTest.kt pass.
  • Manually tested the feed to confirm that posts authored by the logged-in user are no longer displayed.

Checklist

  • Tests have been updated to reflect changes.
  • All existing tests pass after changes.
  • Verified functionality manually.

Related Issue

Fixes #240

@raniabbrk
fix: prevent feed from displaying logged-in user's own posts.
fe3b07f 
-Changed the filtering condition on initialNearbyposts: the user's email is now being checked instead of the username.
@raniabbrk
test: refactor tests in FeedScreenTest.kt class to align with the new…
0b5137c 
… filtering logic.

-Added the userMail parameter field in each post of the testPosts.
-Ensured that the tests pass by making the first post's email the logged-in user's.
@raniabbrk raniabbrk self-assigned this Dec 16, 2024
@raniabbrk raniabbrk added the bug Something isn't working label Dec 16, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Ismaillat
Ismaillat approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@Ismaillat Ismaillat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes! The feed will now only display posts from other users. The code could still be optimized, for example, by filtering the posts directly in the ProximityFetcher. This can be addressed later. Approved for merge.

@raniabbrk raniabbrk merged commit c25a644 into main Dec 18, 2024
3 checks passed
@rihabbelmekki rihabbelmekki deleted the bugfix/hide-own-posts branch December 20, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ismaillat Ismaillat Ismaillat approved these changes

@othbcq othbcq Awaiting requested review from othbcq

@Kenzoud Kenzoud Awaiting requested review from Kenzoud

@mehdi-hamirifou mehdi-hamirifou Awaiting requested review from mehdi-hamirifou

@rihabbelmekki rihabbelmekki Awaiting requested review from rihabbelmekki

Assignees

@raniabbrk raniabbrk

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix see our own posts in feed
2 participants
@raniabbrk @Ismaillat