feat : enable location button in the googleMap

[Ismaillat]

This Pull Request addresses issue #252.

Description:

This PR introduces critical improvements to the GoogleMap screen, enhancing its usability and functionality:

Enable Location Button:

A new button has been added to the GoogleMap screen, allowing users to enable location services directly from the app.
This provides a seamless way for users to grant location permissions and resolve issues with location services without having to exit or reload the screen.

Location Update Handling:

Resolves the issue where users had to reload the GoogleMap screen to update their location after granting location permissions.
The app now dynamically handles location updates, ensuring the GoogleMap screen reflects the user's current position as soon as location services are enabled.

Restricted Functionality Without Location:

Ensures users cannot take pictures unless their location is enabled and updated.
This prevents location-dependent features, like geotagging, from being used without accurate location data, improving data integrity and user experience.

[othbcq]

This PR effectively resolves the reported issue by ensuring that users cannot attempt to take pictures without granting location permissions. The adoption of modern permission handling techniques and the enhancement of the user interface contribute to a more robust and user-friendly application.

However, incorporating the following improvements will further enhance the overall quality of the codebase.

---

1. Remove Unused Constants

The LOCATION_PERMISSION_REQUEST_CODE constant is no longer necessary since you've adopted rememberLauncherForActivityResult for handling permissions. Removing unused constants helps keep the codebase clean and maintainable.

// Remove this line
private const val LOCATION_PERMISSION_REQUEST_CODE: Int = 1001

---

2. Clarify testNoLoca Parameter

The testNoLoca parameter appears to be intended for testing scenarios where location services are disabled. It's important to document its purpose clearly or consider alternative approaches such as dependency injection or mocking for testing purposes.

---

3. Code Duplication

The FirebaseAuth.getInstance() method is called twice to obtain the auth and user instances. To avoid redundancy and improve efficiency, store the instance once and reuse it.

// Consolidate FirebaseAuth instance retrieval
val auth = remember { FirebaseAuth.getInstance() }
val isLoggedIn = auth.currentUser != null
val user = auth.currentUser // Reuse the same instance
val userEmail = user?.email ?: ""

// Remove the redundant call
// val user = FirebaseAuth.getInstance().currentUser

---

Great job overall !

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
64.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Ismaillat]

This PR effectively resolves the reported issue by ensuring that users cannot attempt to take pictures without granting location permissions. The adoption of modern permission handling techniques and the enhancement of the user interface contribute to a more robust and user-friendly application.

However, incorporating the following improvements will further enhance the overall quality of the codebase.

1. Remove Unused Constants

The LOCATION_PERMISSION_REQUEST_CODE constant is no longer necessary since you've adopted rememberLauncherForActivityResult for handling permissions. Removing unused constants helps keep the codebase clean and maintainable.

// Remove this line
private const val LOCATION_PERMISSION_REQUEST_CODE: Int = 1001

2. Clarify testNoLoca Parameter

The testNoLoca parameter appears to be intended for testing scenarios where location services are disabled. It's important to document its purpose clearly or consider alternative approaches such as dependency injection or mocking for testing purposes.

3. Code Duplication

The FirebaseAuth.getInstance() method is called twice to obtain the auth and user instances. To avoid redundancy and improve efficiency, store the instance once and reuse it.

// Consolidate FirebaseAuth instance retrieval
val auth = remember { FirebaseAuth.getInstance() }
val isLoggedIn = auth.currentUser != null
val user = auth.currentUser // Reuse the same instance
val userEmail = user?.email ?: ""

// Remove the redundant call
// val user = FirebaseAuth.getInstance().currentUser

Great job overall !

Thank you for your feedback. I have implemented the requested changes and am now waiting for your feedback.

[othbcq]

Perfect, the changes have been implemented and everything is clean. Approved for merge.