Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve image posting process #296

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

mehdi-hamirifou
Copy link
Contributor

This pull request addresses issue #267

Summary of Changes

  1. UI Enhancements:

    • Added a title ("Post Your Picture") at the top of the ImageReviewScreen, styled with bold white text.
    • Added a description edit field
    • Aligned the description field with its title for a cleaner layout.
    • Positioned the Post and Discard Image buttons at the bottom of the screen.
    • Replaced the Post button with a CircularProgressIndicator during the upload process to indicate loading state.
  2. Logic Updates:

    • Enhanced the description field to support editable mode:
      • Users can click on the description field to enter "edit mode."
      • Added auto-focus and keyboard pop-up when editing starts.
    • Maintained existing upload functionality, ensuring the description is included in the post.
  3. Testing:

    • Updated the existing ImageReviewTest class to include new test cases:
      • Title Display: Verifies the title "Post Your Picture" is displayed.
      • Description Field:
        • Tests that the description field appears and switches to "edit mode" when clicked.
        • Ensures text input works as expected.
      • Loading Indicator:
        • Verifies that the CircularProgressIndicator replaces the Post button during upload.
        • Ensures the Post button is hidden while loading.
    • Retained and refined existing tests for background image, buttons, and scroll behavior.

- Added responsive description field for the post
- Added screen title
@mehdi-hamirifou mehdi-hamirifou linked an issue Dec 18, 2024 that may be closed by this pull request
Copy link
Contributor

@Ismaillat Ismaillat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation demonstrates significant improvements to the ImageReviewScreen. Below are my observations:

UI Enhancements:

The addition of the title "Post Your Picture" is well-executed. Its bold white text and centered placement enhance the screen's visual appeal and provide a clear purpose for the user.
The description field's dual-mode (read and edit) functionality is intuitive, and the layout aligns perfectly with the title for a clean and organized appearance.
The logical positioning of the "Post" and "Discard Image" buttons at the bottom ensures a seamless user experience.

Loading Feedback:

Replacing the "Post" button with a CircularProgressIndicator during uploads provides clear feedback, improving the user experience during potentially slow operations.

Logic and Validation:

Ensuring that the description field is included in the post adds value and aligns with the functionality requirements.
The auto-focus and keyboard pop-up behavior in edit mode enhance the usability of the description field.

State Management:

The handling of uploadStatus is robust, with appropriate responses for loading, success, and error states.
Toast messages and navigation actions are effectively utilized to communicate outcomes to the user.

Testability:

The use of testTag on key UI elements is a thoughtful addition, making the components easily identifiable for automated testing.

The PR is well-aligned with the issue requirements and delivers a user-friendly, functional, and visually appealing ImageReviewScreen. The implementation demonstrates a clear focus on improving the user experience.
This PR is approved for merge. Great work!

@raniabbrk raniabbrk merged commit 52de0b9 into main Dec 19, 2024
3 checks passed
@rihabbelmekki rihabbelmekki deleted the feat/improve-image-posting-process branch December 20, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: improve posting process
3 participants