Fix Moon Rotation and Align Planets to Face the User

[AdrienBousquieEPFL]

Description

This PR addresses the issue where the Moon's rotation was causing its texture to appear inconsistent, and ensures that all celestial objects (Moon and planets) face the user directly for an improved visual experience.

Changes Implemented

Moon Rotation Fix

• Disabled the Moon's rotation by setting rotationSpeed to 0.0f in Moon.kt.
• Ensured the Moon remains stationary, maintaining the intended visual consistency.

Planet Orientation

• Implemented a billboard effect to align all planets and the Moon to face the user's perspective.
• Adjusted the Planet rendering logic in Planet.kt:
  • Added a billboardMatrix to align objects with the camera's look direction.

Code Modifications

• Moon.kt

  • Set rotationSpeed to 0.0f.

• Planet.kt

  • Added new logic for billboard transformations using the camera's view matrix.
  • Reorganized rotation and scaling transformations.
  • Enhanced rendering pipeline to use a combined billboardMatrix and rotation adjustments.

[Kenzoud]

Good job on this pull request. The Moon doesn't move now, which makes more sense than before and the fact that the planets are facing us now, does look better. However, I have noticed some code duplication that could be avoided by using the code snippet that I have provided. I can go ahead and change this part of code if you want. This new code also improves the code coverage of this PR.

[Kenzoud]

Could be replaced by:

// Set billboard matrix
    fun setMatrixRow(matrix: FloatArray, startIndex: Int, x: Float, y: Float, z: Float, w: Float) {
      matrix[startIndex] = x
      matrix[startIndex + 1] = y
      matrix[startIndex + 2] = z
      matrix[startIndex + 3] = w
    }

    // Set billboard matrix
    setMatrixRow(billboardMatrix, 0, rightX, rightY, rightZ, 0f)
    setMatrixRow(billboardMatrix, 4, upX, upY, upZ, 0f)
    setMatrixRow(billboardMatrix, 8, lookX, lookY, lookZ, 0f)
    setMatrixRow(billboardMatrix, 12, 0f, 0f, 0f, 1f)

to avoid code duplication.

[Kenzoud]

Given the time constraint of tomorrow's deadline, I went ahead and took the liberty of adding the commit with my code suggestion to your PR (Sonar cloud now passes with no code duplication and a sufficient code coverage :) ). Approved for merge.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud