feat: implement ProfileRepository and ProfileViewModel #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Kenzoud
commented
Oct 16, 2024
Kenzoud
commented
- Implemented ProfileRepositoryFirestore for managing user profile data with Firestore
- Added ProfileViewModel to handle data fetching, updating, and observing user information
- Integrated LiveData for observing profile data and error handling
- Added methods for retrieving, updating, and observing user profiles - Integrated Firebase Firestore and FirebaseAuth for data storage and authentication - Implemented support for logging out users
This was
linked to
issues
Oct 16, 2024
…yFirestore - Inject FirebaseAuth and instance into ProfileRepositoryFirestore
- Implement unit tests for ProfileViewModel functions: fetchUserProfile, updateUserProfile, and logoutUser
othbcq
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Good job on the implementation. The code looks clean and well-structured. Good use of the MutableStateFlow in the ProfileViewModel, which is well-implemented and allows for reactive state management. You might want to improve code coverage, but overall, great work!
- Added unit tests to improve coverage for the `init`, `getUserProfile`, and `updateUserProfile` functions.
…rofile-repository-viewmodel
|
rihabbelmekki
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.