Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Test Files and Classes, and Move MapKtTest.kt to Correct Package #45

Merged

Conversation

AdrienBousquieEPFL
Copy link
Contributor

Rename Test Files and Classes, and Move MapKtTest.kt to Correct Package

Description

This PR addresses the following changes to improve the structure and naming consistency of test files:

  1. Renamed Test Files and Classes:

    • Renamed several test files and their corresponding classes to ensure they follow proper naming conventions and are correctly linked in Android Studio.
    • This helps in better test discovery and avoids potential issues with mismatches between file names and class names.
  2. Moved MapKtTest.kt to the Correct Package:

    • The MapKtTest.kt file was located in the wrong package. It has been moved to its correct package to match the structure of the source code and ensure tests run properly in the correct context.

Changes Made:

  • File Renames:

    • LoginTest.ktSignInKtTest.kt
    • MapScreenTest.ktMapKtTest.kt
    • CalendarScreenTest.ktCalendarKtTest.kt
    • LandingScreenTest.ktLandingKtTest.kt
    • MenuScreenTest.ktMenuKtTest.kt
    • QuizScreenTest.ktQuizKtTest.kt
    • ProfileScreenTest.ktProfileKtTest.kt
    • SkyTrackerScreen.ktSkyTrackerKtTest.kt
  • Moved File:

    • com/github/lookupgroup27/lookup/ui/overview/MapKtTest.kt -> com/github/lookupgroup27/lookup/ui/map/MapKtTest.kt

Renamed every test class so it links correctly to the file tested.
Moved MapKtTest.kt to the correct package
Copy link

Copy link
Contributor

@Ismaillat Ismaillat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me. I agree with this new project structure and naming conventions.

@AdrienBousquieEPFL AdrienBousquieEPFL merged commit f83388a into main Oct 17, 2024
2 checks passed
@AdrienBousquieEPFL AdrienBousquieEPFL deleted the fix/37-improve-code-coverage-of-the-project branch October 17, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants