-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Implement Profile Information Screen #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added the Profile Information screen with editable fields for username, bio, and email. - Integrated back navigation, save, and sign-out functionality. - Save button enables only when all required fields are filled. - Implemented Firebase authentication integration to prefill email and handle user logout. - Developed unit tests for Profile Information screen components and interactions.
- Implemented vertical scrolling for the ProfileInformationScreen to ensure all components are accessible on smaller devices. - Updated the layout with Modifier.verticalScroll() to allow the screen to scroll when content exceeds the available screen height. - Adjusted related tests to use performScrollTo() for elements that may be off-screen.
…mation-screen # Conflicts: # app/src/main/java/com/github/lookupgroup27/lookup/MainActivity.kt
|
Kenzoud
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is clean. Approved for merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description: Add Profile Information Screen
This PR introduces the Profile Information screen, allowing users to view and edit their username, bio, and email. It includes back navigation, Save (enabled when all fields are filled), and Sign-out functionality. Integrated with Firebase to prefill the email and handle user logout. Added unit tests to verify component rendering, interactions, and data updates. This feature enhances user experience by providing seamless profile management within the app.
Closes issues :
Closes #38