Skip to content

feat: Implement Profile Information Screen #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 18, 2024

Conversation

rihabbelmekki
Copy link
Contributor

@rihabbelmekki rihabbelmekki commented Oct 17, 2024

PR Description: Add Profile Information Screen

This PR introduces the Profile Information screen, allowing users to view and edit their username, bio, and email. It includes back navigation, Save (enabled when all fields are filled), and Sign-out functionality. Integrated with Firebase to prefill the email and handle user logout. Added unit tests to verify component rendering, interactions, and data updates. This feature enhances user experience by providing seamless profile management within the app.

Closes issues :
Closes #38

- Added the Profile Information screen with editable fields for username, bio, and email.
- Integrated back navigation, save, and sign-out functionality.
- Save button enables only when all required fields are filled.
- Implemented Firebase authentication integration to prefill email and handle user logout.
- Developed unit tests for Profile Information screen components and interactions.
- Implemented vertical scrolling for the ProfileInformationScreen to ensure all components are accessible on smaller devices.
- Updated the layout with Modifier.verticalScroll() to allow the screen to scroll when content exceeds the available screen height.
- Adjusted related tests to use performScrollTo() for elements that may be off-screen.
othbcq
othbcq approved these changes Oct 18, 2024
@rihabbelmekki rihabbelmekki requested a review from othbcq October 18, 2024 00:34
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
71.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@rihabbelmekki rihabbelmekki self-assigned this Oct 18, 2024
@Kenzoud Kenzoud self-requested a review October 18, 2024 01:02
Copy link
Contributor

@Kenzoud Kenzoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is clean. Approved for merge.

@rihabbelmekki rihabbelmekki merged commit 155ca75 into main Oct 18, 2024
1 of 2 checks passed
@rihabbelmekki rihabbelmekki deleted the feature/profile-information-screen branch October 18, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Personal Info Screen
3 participants