-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement Google Map Feature with Location Handling #76
Conversation
…Maps integration and testing
…radle for map integration and testing setup
…tes and permission requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the code looks very well structured and integrates the Google Maps feature effectively. However, I think you could add a small toast message to provide clearer feedback on location access:
-If location permission (ACCESS_FINE_LOCATION) isn’t granted, display a toast message informing users that location access is required for the map to function.
Here's an example of how you can implement it:
if (hasLocationPermission) {
..
} else {
ActivityCompat.requestPermissions(
context as Activity,
arrayOf(Manifest.permission.ACCESS_FINE_LOCATION),
LOCATION_PERMISSION_REQUEST_CODE
)
Toast.makeText(context, "Location permission is required to access the map.", Toast.LENGTH_LONG).show()
}
This addition will enhance user experience.
|
Note: I am still working on the implementation of some tests