Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for spikesorting #1078

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Add tests for spikesorting #1078

merged 5 commits into from
Sep 5, 2024

Conversation

CBroz1
Copy link
Member

@CBroz1 CBroz1 commented Aug 22, 2024

Description

This PR adds tests for spikesorting.v1 using existing notebooks

A notable absence is full testing of FigURL utilities pending discussion of how to best interface for CI/CD

Coverage report
---------- coverage: platform linux, python 3.9.19-final-0 -----------
Name                                                       Stmts   Miss  Cover   Missing
----------------------------------------------------------------------------------------
src/spyglass/spikesorting/analysis/v1/group.py                92     34    63%   76-78, 107-126, 176, 187-195, 199, 214, 232-247, 277, 292
src/spyglass/spikesorting/analysis/v1/unit_annotation.py      41      2    95%   75, 138
src/spyglass/spikesorting/imported.py                         64     35    45%   49-58, 64, 70, 92-111, 119-132, 137-148
src/spyglass/spikesorting/spikesorting_merge.py               91     19    79%   106, 134-142, 213-228, 259
src/spyglass/spikesorting/utils.py                            97     48    51%   76-78, 89, 102-103, 111-115, 120-124, 146-152, 161-204, 237, 243-248, 250-255, 260-278, 282
src/spyglass/spikesorting/v1/artifact.py                      86     25    71%   68, 98-99, 241, 282-316, 335-357
src/spyglass/spikesorting/v1/curation.py                     157     33    79%   92-93, 144-162, 241-266, 357-364, 388, 414, 440-443, 478-480
src/spyglass/spikesorting/v1/figurl_curation.py               85     55    35%   47-58, 69-103, 122-166, 170-171, 182, 200-267
src/spyglass/spikesorting/v1/metric_curation.py              189     29    85%   87, 132, 136-138, 158, 189-190, 236, 285, 375, 420, 429-430, 434, 479-498, 557
src/spyglass/spikesorting/v1/metric_utils.py                  19      5    74%   43-50, 58
src/spyglass/spikesorting/v1/recording.py                    202     30    85%   82, 85, 121, 156-157, 234, 373-384, 406-421, 442-449, 468, 470, 475, 498-499
src/spyglass/spikesorting/v1/sorting.py                      117     27    77%   99, 130-131, 202, 206, 231-241, 253, 269-275, 319-348, 384
src/spyglass/spikesorting/v1/utils.py                         27      2    93%   87, 97
----------------------------------------------------------------------------------------
TOTAL                                                       1267    344    73%

Checklist:

  • No. This PR should be accompanied by a release: (yes/no/unsure)
  • N/a. If release, I have updated the CITATION.cff
  • No. This PR makes edits to table definitions: (yes/no)
  • N/a. If table edits, I have included an alter snippet for release notes.
  • N/a. If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • N/a. I have added/edited docs/notebooks to reflect the changes

@CBroz1 CBroz1 marked this pull request as ready for review August 23, 2024 20:05
pyproject.toml Show resolved Hide resolved
src/spyglass/spikesorting/v1/utils.py Show resolved Hide resolved
src/spyglass/spikesorting/v1/utils.py Show resolved Hide resolved
@edeno edeno self-requested a review September 5, 2024 18:11
@edeno edeno merged commit f182676 into LorenFrankLab:master Sep 5, 2024
7 checks passed
@CBroz1 CBroz1 deleted the tsp branch September 5, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants