Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent error from unitless spike group #1083

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Prevent error from unitless spike group #1083

merged 4 commits into from
Aug 29, 2024

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Aug 29, 2024 •
edited
Loading

Description

fixes #1082

  • prevents key errors when extracting UnitWaveformFeatures from a curated sorting with no units

fixes #1077

  • correct call to get_spike_times in SpikeSortingOutput.get_spike_indicator

Checklist:

  • No This PR should be accompanied by a release: (yes/no/unsure)
  • NAIf release, I have updated the CITATION.cff
  • No This PR makes edits to table definitions: (yes/no)
  • NA If table edits, I have included an alter snippet for release notes.
  • NA If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • NA I have added/edited docs/notebooks to reflect the changes

@samuelbray32 samuelbray32 marked this pull request as ready for review August 29, 2024 16:05
@samuelbray32 samuelbray32 merged commit d4dbc23 into master Aug 29, 2024
7 checks passed
@samuelbray32 samuelbray32 deleted the 1082_fix branch August 29, 2024 16:29
@samuelbray32 samuelbray32 mentioned this pull request Sep 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBroz1 CBroz1 CBroz1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in UnitWaveformFeatures with sort with no units SpikeSortingOutput calls non-existent method
2 participants
@samuelbray32 @CBroz1