Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1080 #1099

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Fix 1080 #1099

merged 2 commits into from
Sep 10, 2024

Conversation

CBroz1
Copy link
Member

@CBroz1 CBroz1 commented Sep 10, 2024

Description

#1053 made an edit to _compute_metric control flow anticipating an early return, but instead allowed isi_violation to be recomputed for each unit. This is present in the most recent release, but will result in failed saving, as shown in #1080, because the embedded dictionary will not be able to save to json

Checklist:

  • No. This PR should be accompanied by a release: (yes/no/unsure)
  • N/a. If release, I have updated the CITATION.cff
  • No. This PR makes edits to table definitions: (yes/no)
  • N/a. If table edits, I have included an alter snippet for release notes.
  • No. If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • N/a. I have added/edited docs/notebooks to reflect the changes

@CBroz1 CBroz1 marked this pull request as ready for review September 10, 2024 15:55
@edeno edeno merged commit 991fc76 into LorenFrankLab:master Sep 10, 2024
7 checks passed
@CBroz1 CBroz1 deleted the 1080 branch October 22, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants