Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1101 #1103

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Fix #1101 #1103

merged 2 commits into from
Sep 12, 2024

Conversation

CBroz1
Copy link
Member

@CBroz1 CBroz1 commented Sep 11, 2024 •
edited
Loading

Description

Fixing bug caused by #870 where the parent of the video folder was used as the storage location for the video file.

Checklist:

  • No. This PR should be accompanied by a release: (yes/no/unsure)
  • N/a. If release, I have updated the CITATION.cff
  • No. This PR makes edits to table definitions: (yes/no)
  • N/a If table edits, I have included an alter snippet for release notes.
  • If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • N/a I have added/edited docs/notebooks to reflect the changes

@CBroz1 CBroz1 marked this pull request as ready for review September 12, 2024 15:08
@CBroz1 CBroz1 linked an issue Sep 12, 2024 that may be closed by this pull request
Error when finding video #1101
Closed
@edeno edeno merged commit 6c8a566 into LorenFrankLab:master Sep 12, 2024
7 checks passed
@CBroz1 CBroz1 deleted the 1101 branch October 22, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edeno edeno edeno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when finding video
2 participants
@CBroz1 @edeno