Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust no-transact pop hashing mechanism #1108

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Conversation

CBroz1
Copy link
Member

@CBroz1 CBroz1 commented Sep 13, 2024

Description

Previous hashing mechanism used numpy arrays. Empty arrays can have unexpected hashes. This explicitly fetches the data from the tables to avoid a seeming error when populate is called in a table with an empty key_source

Checklist:

  • No. This PR should be accompanied by a release: (yes/no/unsure)
  • N/a. If release, I have updated the CITATION.cff
  • No. This PR makes edits to table definitions: (yes/no)
  • N/a. If table edits, I have included an alter snippet for release notes.
  • No. If this PR makes changes to position, I ran the relevant tests locally.
  • Yes. I have updated the CHANGELOG.md with PR number and description.
  • N/a. I have added/edited docs/notebooks to reflect the changes

@CBroz1 CBroz1 marked this pull request as ready for review September 13, 2024 19:05
@edeno edeno merged commit c5ee862 into LorenFrankLab:master Sep 13, 2024
7 checks passed
@CBroz1 CBroz1 deleted the hsh branch October 22, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants