Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add objects to analysis file before insert #1112

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Add objects to analysis file before insert #1112

merged 2 commits into from
Sep 16, 2024

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Sep 16, 2024

Description

Fixes #1107:

  • add position and velocity object to the analysis nwb file before inserting to AnalysisNwbfile
  • prevents mismatched checksum/size from altering file after insert

Checklist:

  • No This PR should be accompanied by a release: (yes/no/unsure)
  • NA If release, I have updated the CITATION.cff
  • No This PR makes edits to table definitions: (yes/no)
  • NA If table edits, I have included an alter snippet for release notes.
  • NA If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • NA I have added/edited docs/notebooks to reflect the changes

@samuelbray32 samuelbray32 marked this pull request as ready for review September 16, 2024 18:41
@edeno edeno merged commit a711874 into master Sep 16, 2024
6 checks passed
@edeno edeno deleted the 1107_fix branch September 16, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

file size error in DLC pipeline
2 participants