Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null config_tasks value #1120

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Fix null config_tasks value #1120

merged 4 commits into from
Sep 20, 2024

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Sep 19, 2024 •
edited
Loading

Description

Fixes #1119

  • make the null value when getting config_tasks an empty list to prevent non-iterable error

Fixes #1122

  • alter warning to avoid error

Fixes #1123

  • Update test of position interval map for updated null key insert

Checklist:

  • N This PR should be accompanied by a release: (yes/no/unsure)
  • NA If release, I have updated the CITATION.cff
  • N This PR makes edits to table definitions: (yes/no)
  • NA If table edits, I have included an alter snippet for release notes.
  • NA If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • NA I have added/edited docs/notebooks to reflect the changes

@samuelbray32 samuelbray32 marked this pull request as ready for review September 19, 2024 20:44
CBroz1
CBroz1 requested changes Sep 20, 2024
View reviewed changes
tests/common/test_behav.py Show resolved Hide resolved
@edeno edeno merged commit 2668ddc into master Sep 20, 2024
7 checks passed
@edeno edeno deleted the 1119_fix branch September 20, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBroz1 CBroz1 CBroz1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@samuelbray32 @CBroz1 @edeno