Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up electrodes import #1125

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

magland
Copy link
Contributor

@magland magland commented Sep 19, 2024

Description

Checklist:

  • This PR should be accompanied by a release: no
  • N/A. If release, I have updated the CITATION.cff
  • This PR makes edits to table definitions: no
  • N/A. If table edits, I have included an alter snippet for release notes.
  • N/A. If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • N/A. I have added/edited docs/notebooks to reflect the changes

@magland magland changed the title [WIP] speed up electrodes import speed up electrodes import Sep 19, 2024
@magland
Copy link
Contributor Author

magland commented Sep 19, 2024

I tested this and it seems to have resulted in the desired inserts into the Electrodes table, and the run time for that step was around 20 seconds compared to 14 minutes.

@edeno edeno requested a review from CBroz1 September 19, 2024 22:44
@CBroz1 CBroz1 merged commit 860d470 into LorenFrankLab:master Sep 20, 2024
7 checks passed
@CBroz1
Copy link
Member

CBroz1 commented Sep 20, 2024

Thanks for this, @magland !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redundant time-consuming insertion of electrodes during import
2 participants