Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix waveform params in metric curation #1132

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Fix waveform params in metric curation #1132

merged 3 commits into from
Sep 25, 2024

Conversation

edeno
Copy link
Collaborator

@edeno edeno commented Sep 25, 2024

Description

Fixes waveform_params dict in metric curation so that the sparse keyword is handled when set.

Checklist:

  • This PR should be accompanied by a release: (yes/no/unsure)
  • If release, I have updated the CITATION.cff
  • This PR makes edits to table definitions: (yes/no)
  • If table edits, I have included an alter snippet for release notes.
  • If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • I have added/edited docs/notebooks to reflect the changes

@edeno edeno merged commit 32dc077 into master Sep 25, 2024
7 checks passed
@edeno edeno deleted the fix-waveform-params branch September 25, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelbray32 samuelbray32 samuelbray32 approved these changes

@CBroz1 CBroz1 Awaiting requested review from CBroz1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

waveform extractor issue with keyword 'sparse'
2 participants
@edeno @samuelbray32