-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pytests for decoding pipeline #1155
Open
CBroz1
wants to merge
8
commits into
LorenFrankLab:master
Choose a base branch
from
CBroz1:dpt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CBroz1
commented
Oct 9, 2024
@@ -586,7 +587,8 @@ def get_ahead_behind_distance(self, track_graph=None, time_slice=None): | |||
classifier.environments[0].track_graph, *traj_data | |||
) | |||
else: | |||
position_info = self.fetch_position_info(self.fetch1("KEY")).loc[ | |||
# `fetch_position_info` returns a tuple | |||
position_info = self.fetch_position_info(self.fetch1("KEY"))[0].loc[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds coverage of the decoding pipeline to our test suite. The tests themselves could use greater specificity - these are generic checks of the right object type or column names in a dataframe. Maybe a future PR could use this infrastructure to ensure the data are processed correctly?
Coverage
This motivated a couple edits to the pipeline itself
decoding_merge
: previously had a couple places that ranfetch1
on unrestricted/uninstanced class objects. Swapping out formerge_restrict_class
fixed these issuesdecoding_merge.create_decoding_view
: previously expected a tuple fromfetch_linear_position_info
, which caused errors because it returns just the dataframeclusterless.py
andcore.py
: swapped out raising error for logging error to align with broader package insert patternscore.py
: Partially addressingDecodingParameters.insert_default
errors on new declaration #1158 with a check of whether or notvars
will work on the passed params.Checklist:
CITATION.cff
alter
snippet for release notes.CHANGELOG.md
with PR number and description.