Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No transact bug #1178

Merged
merged 3 commits into from
Nov 6, 2024
Merged

No transact bug #1178

merged 3 commits into from
Nov 6, 2024

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Nov 6, 2024 •
edited
Loading

Description

  • Catches error case in hashing where only single key is being populated
  • Fixes typo #1177 typo

Checklist:

  • N This PR should be accompanied by a release: (yes/no/unsure)
  • NA If release, I have updated the CITATION.cff
  • N This PR makes edits to table definitions: (yes/no)
  • NA If table edits, I have included an alter snippet for release notes.
  • If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • NA I have added/edited docs/notebooks to reflect the changes

edeno
edeno requested changes Nov 6, 2024
View reviewed changes
src/spyglass/utils/dj_mixin.py Outdated
if not (parents := self.parents(as_objects=True, primary=True)):
# Should not happen, as this is only called from populated tables
raise RuntimeError("No upstream tables found for upstream hash.")

if isintance(keys, dict):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be isinstance

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also linting

@edeno edeno marked this pull request as ready for review November 6, 2024 20:03
@edeno edeno self-requested a review November 6, 2024 20:03
@edeno edeno merged commit dc08c25 into master Nov 6, 2024
16 checks passed
@edeno edeno deleted the no_transact_bug branch November 6, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edeno edeno edeno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typo
2 participants
@samuelbray32 @edeno