Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug coverage #28

Merged
merged 5 commits into from
Aug 4, 2023
Merged

Debug coverage #28

merged 5 commits into from
Aug 4, 2023

Conversation

rly
Copy link
Collaborator

@rly rly commented Aug 4, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@5b6bd43). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage        ?   69.96%           
=======================================
  Files           ?       12           
  Lines           ?     1182           
  Branches        ?        0           
=======================================
  Hits            ?      827           
  Misses          ?      355           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly
Copy link
Collaborator Author

rly commented Aug 4, 2023

I figured it out. The package needs to be installed in editable mode for coverage to find the source files.

The amount of branching in this one workflow seems excessive. We could pull the coverage computation to a separate workflow.

@rly rly requested review from samuelbray32 and edeno August 4, 2023 21:21
@edeno edeno merged commit 75f5ef8 into main Aug 4, 2023
10 checks passed
@edeno edeno deleted the rly-patch-1 branch August 4, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants