Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client versions between 1.0.0 and 1.2.5 #2

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

Pixaurora
Copy link
Contributor

This does not include the latest commit's changes where many stat-related mixins were removed in favor of hooking directly into when stats get changed instead, but adds support for all other changes. I hope you like it!!

Copy link
Owner

@LostLuma LostLuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your changeset statistics involving blocks / items were never initiated, because stats were initialized at the start of the program instead of when the Minecraft class is created (even though this is correct in the existing 1.3+ code). I fixed this in addition to pulling in the upstream changes:

@Mixin(Minecraft.class)
public class MinecraftMixin {
-   @Inject(method = "main", at = @At("HEAD"))
-   private static void onMain(CallbackInfo callbackInfo) {
+   @Inject(method = "<init>", at = @At("TAIL"))
+   private void onInit(CallbackInfo callbackInfo) {
        Stats.init();
    }

@LostLuma LostLuma changed the title add client versions between 1.0.0 and 1.2.5 Add client versions between 1.0.0 and 1.2.5 Nov 10, 2023
@LostLuma LostLuma merged commit 6eb1419 into LostLuma:stardust Nov 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants