Skip to content

Conversation

@ivangeorgiew
Copy link

Fixes the incorrect range for @diagnostic completions.
The issue was discussed in saghen/blink.cmp#1985 (comment)

@gemini-code-assist
Copy link

Summary of Changes

Hello @ivangeorgiew, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug affecting diagnostic completions, specifically addressing an incorrect range calculation for the "textEdit.finish" property. By adjusting this calculation, the PR ensures that diagnostic completions are applied precisely, preventing partial replacements or unintended character retention, thereby improving the accuracy and user experience of the completion feature.

Highlights

  • Diagnostic Completion Range: This pull request fixes an issue where the "textEdit.finish" range for "@diagnostic" completions was incorrectly calculated, leading to an off-by-one error. The "finish" position is now correctly set to include the full length of the text being replaced.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an off-by-one error in calculating the finish position for textEdit during diagnostic completions. By removing the - 1 from the calculation, the change correctly sets the end of the replacement range, assuming an exclusive end position which is standard. This fix is applied consistently for both @diagnostic mode and name completions, ensuring completion items replace the correct amount of text. The changes are correct and improve the completion behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant